Deprecate xpay-handle-pay#9254
Open
Lagrang3 wants to merge 3 commits into
Open
Conversation
Lagrang3
force-pushed
the
remove-pay-backend
branch
from
fa2c776 to
fa8038a
Compare
Lagrang3
force-pushed
the
remove-pay-backend
branch
3 times, most recently
from
89f8387 to
72d3263
Compare
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-Deprecated: Config: option `xpay-handle-pay`, `pay` is deprecated and will be replaced by `xpay` in v27.03. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
remove-pay-backend
branch
from
72d3263 to
3660f6f
Compare
Collaborator
Author
|
Lagrang3
added
the
Status::Ready for Review
Lagrang3
force-pushed
the
remove-pay-backend
branch
from
3660f6f to
cc78e39
Compare
Collaborator
Author
|
After this afea381 in v26.06 we were having xpay processing all payments by default. This meant that These tests could have been enabled for
|
Lagrang3
force-pushed
the
remove-pay-backend
branch
4 times, most recently
from
e84e771 to
c500a89
Compare
- add missing deprecation annotation to "pay" command, - fix tests that required allow-deprecated-apis=True in order to continue using "pay", - change "pay" to "xpay" in those tests that are NOT testing "pay" directly but just want to make a payment, - and in tests that could be relevant for both "xpay" and "pay", use both. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
remove-pay-backend
branch
from
c500a89 to
529fff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustyrussell deprecated
payin #9110, but he forgot to deprecatexpay-handle-pay.This PR deprecates
xpay-handle-payfor v26.09.